On Thu, Jan 23, 2020 at 10:05:50AM -0700, Jeffrey Hugo wrote: > On 1/23/2020 4:18 AM, Manivannan Sadhasivam wrote: > > This commit adds support for registering MHI controller drivers with > > the MHI stack. MHI controller drivers manages the interaction with the > > MHI client devices such as the external modems and WiFi chipsets. They > > are also the MHI bus master in charge of managing the physical link > > between the host and client device. > > > > This is based on the patch submitted by Sujeev Dias: > > https://lkml.org/lkml/2018/7/9/987 > > > > Signed-off-by: Sujeev Dias <sdias@xxxxxxxxxxxxxx> > > Signed-off-by: Siddartha Mohanadoss <smohanad@xxxxxxxxxxxxxx> > > [jhugo: added static config for controllers and fixed several bugs] > > Signed-off-by: Jeffrey Hugo <jhugo@xxxxxxxxxxxxxx> > > [mani: removed DT dependency, splitted and cleaned up for upstream] > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx> > > --- > > drivers/bus/Kconfig | 1 + > > drivers/bus/Makefile | 3 + > > drivers/bus/mhi/Kconfig | 14 + > > drivers/bus/mhi/Makefile | 2 + > > drivers/bus/mhi/core/Makefile | 3 + > > drivers/bus/mhi/core/init.c | 404 +++++++++++++++++++++++++++++ > > drivers/bus/mhi/core/internal.h | 169 ++++++++++++ > > include/linux/mhi.h | 438 ++++++++++++++++++++++++++++++++ > > include/linux/mod_devicetable.h | 12 + > > 9 files changed, 1046 insertions(+) > > create mode 100644 drivers/bus/mhi/Kconfig > > create mode 100644 drivers/bus/mhi/Makefile > > create mode 100644 drivers/bus/mhi/core/Makefile > > create mode 100644 drivers/bus/mhi/core/init.c > > create mode 100644 drivers/bus/mhi/core/internal.h > > create mode 100644 include/linux/mhi.h > > > > diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig > > index 50200d1c06ea..383934e54786 100644 > > --- a/drivers/bus/Kconfig > > +++ b/drivers/bus/Kconfig > > @@ -202,5 +202,6 @@ config DA8XX_MSTPRI > > peripherals. > > source "drivers/bus/fsl-mc/Kconfig" > > +source "drivers/bus/mhi/Kconfig" > > endmenu > > diff --git a/drivers/bus/Makefile b/drivers/bus/Makefile > > index 1320bcf9fa9d..05f32cd694a4 100644 > > --- a/drivers/bus/Makefile > > +++ b/drivers/bus/Makefile > > @@ -34,3 +34,6 @@ obj-$(CONFIG_UNIPHIER_SYSTEM_BUS) += uniphier-system-bus.o > > obj-$(CONFIG_VEXPRESS_CONFIG) += vexpress-config.o > > obj-$(CONFIG_DA8XX_MSTPRI) += da8xx-mstpri.o > > + > > +# MHI > > +obj-$(CONFIG_MHI_BUS) += mhi/ > > diff --git a/drivers/bus/mhi/Kconfig b/drivers/bus/mhi/Kconfig > > new file mode 100644 > > index 000000000000..a8bd9bd7db7c > > --- /dev/null > > +++ b/drivers/bus/mhi/Kconfig > > @@ -0,0 +1,14 @@ > > +# SPDX-License-Identifier: GPL-2.0 > > first time I noticed this, although I suspect this will need to be corrected > "everywhere" - > Per the SPDX website, the "GPL-2.0" label is deprecated. It's replacement > is "GPL-2.0-only". > I think all instances should be updated to "GPL-2.0-only" No, it is fine, please read Documentation/process/license-rules.rst thanks, greg k-h
