Hi Arnd, On Thu, Jan 23, 2020 at 12:45:32PM +0100, Arnd Bergmann wrote: > On Thu, Jan 23, 2020 at 12:19 PM Manivannan Sadhasivam > <manivannan.sadhasivam@xxxxxxxxxx> wrote: > > > > QMI helpers are not always used by Qualcomm platforms. One of the > > exceptions is the external modems available in near future. As a > > side effect of removing the dependency, it is also going to loose > > COMPILE_TEST build coverage. > > > > Cc: Andy Gross <agross@xxxxxxxxxx> > > Cc: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> > > Cc: linux-arm-msm@xxxxxxxxxxxxxxx > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx> > > --- > > drivers/soc/qcom/Kconfig | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig > > index 79d826553ac8..ca057bc9aae6 100644 > > --- a/drivers/soc/qcom/Kconfig > > +++ b/drivers/soc/qcom/Kconfig > > @@ -88,7 +88,6 @@ config QCOM_PM > > > > config QCOM_QMI_HELPERS > > tristate > > - depends on ARCH_QCOM || COMPILE_TEST > > depends on NET > > Should this be moved out of drivers/soc/ then? > Good question. I thought this change will trigger the question anyway ;) Will need to hear from Bjorn on this. I agree that it should be moved out of drivers/soc! Thanks, Mani > Arnd
