On Wed, Jan 01, 2020 at 11:36:07PM -0800, Bjorn Andersson wrote: > On Tue 31 Dec 19:37 PST 2019, Brian Masney wrote: > > > Add 32 bit implmentations of the functions > > __qcom_scm_iommu_secure_ptbl_size() and > > __qcom_scm_iommu_secure_ptbl_init() that are required by the qcom_iommu > > driver. > > > > Hi Brian, > > This looks good, but I was hoping to hoping to reach a conclusion and > merge [1] - which in patch 16 squashes the argument filling boiler plate > code of the 32 and 64-bit version of scm and hence implements the same. > > If you have time to take a peek at this series I would greatly > appreciate it (not a lot of people testing 32-bit these days...) > > [1] https://patchwork.kernel.org/project/linux-arm-msm/list/?series=215943 I agree to drop what I proposed here and go with that series instead. It's a big improvement over what's upstream now. I left a Tested-by on that cover letter. Brian