On Fri, Jan 3, 2020 at 11:31 AM Sam Ravnborg <sam@xxxxxxxxxxxx> wrote:
>
> Hi Rob.
>
> On Fri, Jan 03, 2020 at 10:30:24AM -0800, Rob Clark wrote:
> > From: Rob Clark <robdclark@xxxxxxxxxxxx>
> >
> > Signed-off-by: Rob Clark <robdclark@xxxxxxxxxxxx>
> > ---
> > drivers/gpu/drm/panel/panel-simple.c | 32 ++++++++++++++++++++++++++++
> > 1 file changed, 32 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> > index 5d487686d25c..895a25cfc54f 100644
> > --- a/drivers/gpu/drm/panel/panel-simple.c
> > +++ b/drivers/gpu/drm/panel/panel-simple.c
> > @@ -680,6 +680,35 @@ static const struct panel_desc auo_b116xw03 = {
> > },
> > };
> >
> > +static const struct drm_display_mode auo_b116xak01_mode = {
> > + .clock = 69300,
> > + .hdisplay = 1366,
> > + .hsync_start = 1366 + 48,
> > + .hsync_end = 1366 + 48 + 32,
> > + .htotal = 1366 + 48 + 32 + 10,
> > + .vdisplay = 768,
> > + .vsync_start = 768 + 4,
> > + .vsync_end = 768 + 4 + 6,
> > + .vtotal = 768 + 4 + 6 + 15,
> > + .vrefresh = 60,
> > + .flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC,
> > +};
> > +
> > +static const struct panel_desc auo_b116xak01 = {
> > + .modes = &auo_b116xak01_mode,
> > + .num_modes = 1,
> > + .bpc = 6,
> > + .size = {
> > + .width = 256,
> > + .height = 144,
> > + },
> > + .delay = {
> > + .hpd_absent_delay = 200,
> > + },
> > + .bus_format = MEDIA_BUS_FMT_RGB666_1X18,
> > + .connector_type = DRM_MODE_CONNECTOR_eDP,
> > +};
> Entries in alphabetical order - check.
> .connector_type specified - check.
> .flags and .bus_format specified - check.
> .bus_flags not specified but optional - OK.
>
> > +
> > static const struct drm_display_mode auo_b133xtn01_mode = {
> > .clock = 69500,
> > .hdisplay = 1366,
> > @@ -3125,6 +3154,9 @@ static const struct of_device_id platform_of_match[] = {
> > }, {
> > .compatible = "auo,b133htn01",
> > .data = &auo_b133htn01,
> > + }, {
> > + .compatible = "auo,b116xa01",
> > + .data = &auo_b116xak01,
> This entry most also be in alphabetical order.
>
> > }, {
> > .compatible = "auo,b133xtn01",
> > .data = &auo_b133xtn01,
>
> Please fix and resend.
>
> I am in general holding back on patches to panel-simple.
> I hope we can reach a decision for the way forward with the bindings
> files sometimes next week.
I've fixed the sort-order and the couple things you've pointed out in
the bindings. Not sure if you want me to resend immediately or
hang-tight until the bindings discussion is resolved?
BR,
-R
