Hi Bjorn, On 12/29/2019 9:05 AM, Bjorn Andersson wrote: > On Thu 19 Dec 02:41 PST 2019, Sricharan R wrote: >> diff --git a/drivers/pinctrl/qcom/pinctrl-ipq6018.c b/drivers/pinctrl/qcom/pinctrl-ipq6018.c > [..] >> +static const struct msm_function ipq6018_functions[] = { > [..] >> + FUNCTION(qpic_pad), >> + FUNCTION(qpic_pad0), >> + FUNCTION(qpic_pad1), >> + FUNCTION(qpic_pad2), >> + FUNCTION(qpic_pad3), >> + FUNCTION(qpic_pad4), >> + FUNCTION(qpic_pad5), >> + FUNCTION(qpic_pad6), >> + FUNCTION(qpic_pad7), >> + FUNCTION(qpic_pad8), > > Shouldn't the qpic_padN entries be removed now? (Please double check the > rest as well) > ok, will fix and others as well. Regards, Sricharan -- "QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation