Hi, Yangtao: On Sat, 2019-12-28 at 18:35 +0000, Yangtao Li wrote: > Use devm_platform_ioremap_resource() to simplify code. > Reviewed-by: CK Hu <ck.hu@xxxxxxxxxxxx> > Signed-off-by: Yangtao Li <tiny.windzz@xxxxxxxxx> > --- > drivers/mailbox/mtk-cmdq-mailbox.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c > index 9a6ce9f5a7db..7f9e34b021c8 100644 > --- a/drivers/mailbox/mtk-cmdq-mailbox.c > +++ b/drivers/mailbox/mtk-cmdq-mailbox.c > @@ -458,7 +458,6 @@ static struct mbox_chan *cmdq_xlate(struct mbox_controller *mbox, > static int cmdq_probe(struct platform_device *pdev) > { > struct device *dev = &pdev->dev; > - struct resource *res; > struct cmdq *cmdq; > int err, i; > > @@ -466,8 +465,7 @@ static int cmdq_probe(struct platform_device *pdev) > if (!cmdq) > return -ENOMEM; > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - cmdq->base = devm_ioremap_resource(dev, res); > + cmdq->base = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(cmdq->base)) { > dev_err(dev, "failed to ioremap gce\n"); > return PTR_ERR(cmdq->base);