On Thu 19 Dec 02:29 PST 2019, sthella@xxxxxxxxxxxxxx wrote: > On 2019-12-18 11:44, Bjorn Andersson wrote: > > On Tue 17 Dec 01:20 PST 2019, Shyam Kumar Thella wrote: [..] > > > +subsys_initcall(sdam_init); > > > > module_platform_driver(sdam_driver), unless you have some strong > > arguments for why this needs to be subsys_initcall > There are some critical sybsystems which depend on nvmem data. So I would > prefer using subsys_initcall(). How critical? Needed to kernel module loading? Can you please document this need somehow? (either a comment here or something in the commit message). Be specific. THanks, Bjorn