On Thu, Dec 05, 2019 at 07:56:10AM -0600, Rob Herring wrote: > On Wed, Dec 4, 2019 at 6:25 PM Brian Masney <masneyb@xxxxxxxxxxxxx> wrote: > > > > Add support for clock-based vibrator devices where the speed can be > > controlled by changing the duty cycle. > > > > Signed-off-by: Brian Masney <masneyb@xxxxxxxxxxxxx> > > --- > > .../bindings/input/clk-vibrator.yaml | 60 +++++++++++++++++++ > > 1 file changed, 60 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/input/clk-vibrator.yaml > > > > diff --git a/Documentation/devicetree/bindings/input/clk-vibrator.yaml b/Documentation/devicetree/bindings/input/clk-vibrator.yaml > > new file mode 100644 > > index 000000000000..2103a5694fad > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/input/clk-vibrator.yaml > > @@ -0,0 +1,60 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/bindings/input/clk-vibrator.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Clock vibrator > > + > > +maintainers: > > + - Brian Masney <masneyb@xxxxxxxxxxxxx> > > + > > +description: | > > + Support for clock-based vibrator devices where the speed can be controlled > > + by changing the duty cycle. > > + > > +properties: > > + compatible: > > + const: clk-vibrator > > + > > + clocks: > > + maxItems: 1 > > + > > + clock-names: > > + description: output clock that controls the speed > > + items: > > + - const: core > > No point in making up a name when there's only one clock, so drop. OK, will do. > > > + > > + clock-frequency: true > > Given the frequency is variable, what does this mean in this case? The clock frequency is fixed. The duty cycle is what's variable. Brian > > > + enable-gpios: > > + maxItems: 1 > > + > > + vcc-supply: > > + description: Regulator that provides power > > + > > +required: > > + - compatible > > + - clocks > > + - clock-names > > + - clock-frequency > > Add: > > additionalProperties: false > > > + > > +examples: > > + - | > > + #include <dt-bindings/clock/qcom,mmcc-msm8974.h> > > + #include <dt-bindings/gpio/gpio.h> > > + > > + vibrator { > > + compatible = "clk-vibrator"; > > + > > + vcc-supply = <&pm8941_l19>; > > + > > + clocks = <&mmcc CAMSS_GP1_CLK>; > > + clock-names = "core"; > > + clock-frequency = <24000>; > > + > > + enable-gpios = <&msmgpio 60 GPIO_ACTIVE_HIGH>; > > + > > + pinctrl-names = "default"; > > + pinctrl-0 = <&vibrator_pin>; > > + }; > > -- > > 2.21.0 > >
