On Wed, Nov 27, 2019 at 11:29:09AM +0100, Ulf Hansson wrote: [...] > +struct device *psci_dt_attach_cpu(int cpu) > +{ > + struct device *dev; > + > + /* Currently limit the hierarchical topology to be used in OSI mode. */ > + if (!psci_has_osi_support()) > + return NULL; > + > + dev = dev_pm_domain_attach_by_name(get_cpu_device(cpu), "psci"); > + if (IS_ERR_OR_NULL(dev)) > + return dev; > + > + pm_runtime_irq_safe(dev); > + if (cpu_online(cpu)) It is unclear to me how we handle (or rather we don't) CPU hotplug with this series - it does not look OK unless genpd code manages that automatically. Lorenzo