Re: [PATCH 5/6] soc: qcom: rpmhpd: Add SC7180 RPMH power-domains

[Stephen Boyd <swboyd@xxxxxxxxxxxx>]

Quoting Sibi Sankar (2019-11-18 09:40:21)
> Add support for cx/mx/gfx/lcx/lmx/mss power-domains found
> on SC7180 SoCs.
> 
> Signed-off-by: Sibi Sankar <sibis@xxxxxxxxxxxxxx>
> ---

Reviewed-by: Stephen Boyd <swboyd@xxxxxxxxxxxx>

>  drivers/soc/qcom/rpmhpd.c | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/drivers/soc/qcom/rpmhpd.c b/drivers/soc/qcom/rpmhpd.c
> index 3b109ee67a4d2..599208722650d 100644
> --- a/drivers/soc/qcom/rpmhpd.c
> +++ b/drivers/soc/qcom/rpmhpd.c
> @@ -166,7 +166,26 @@ static const struct rpmhpd_desc sm8150_desc = {
>         .num_pds = ARRAY_SIZE(sm8150_rpmhpds),
>  };
>  
> +/* SC7180 RPMH powerdomains */
> +

Nitpick: Remove the extra newline

> +static struct rpmhpd *sc7180_rpmhpds[] = {
> +       [SC7180_CX] = &sdm845_cx,
> +       [SC7180_CX_AO] = &sdm845_cx_ao,
> +       [SC7180_GFX] = &sdm845_gfx,
> +       [SC7180_MX] = &sdm845_mx,
> +       [SC7180_MX_AO] = &sdm845_mx_ao,
> +       [SC7180_LMX] = &sdm845_lmx,
> +       [SC7180_LCX] = &sdm845_lcx,
> +       [SC7180_MSS] = &sdm845_mss,
> +};