Re: [PATCH v1] Bluetooth: hci_qca: Enable clocks required for BT SOC

[bgodavar@xxxxxxxxxxxxxx]

Hi Stephen,

On 2019-11-14 22:49, Stephen Boyd wrote:
> Quoting Balakrishna Godavarthi (2019-11-14 00:14:30)
> > @@ -1423,6 +1427,20 @@ static int qca_power_off(struct hci_dev *hdev)
> >         return 0;
> >  }
> >
> > +static int qca_power_on(struct qca_serdev *qcadev)
> > +{
> > +       int err;
> > +
> > +       if (qcadev->susclk) {
>
> clk_prepare_enable() shouldn't return anything besides 0 when passed a
> NULL pointer. Please drop this if condition in addition to the one on
> the clk_disable_unprepare().
>
> > +               err = clk_prepare_enable(qcadev->susclk);
> > +               if (err)
> > +                       return err;
> > +       }

[Bala]: will update.

Regards
Balakrishna