On Sat, Nov 16, 2019 at 05:27:36PM -0800, Stephen Boyd wrote: > Quoting Brian Masney (2019-11-16 10:54:57) > > > diff --git a/drivers/clk/qcom/mmcc-msm8974.c b/drivers/clk/qcom/mmcc-msm8974.c > > > index bcb0a397ef91..015426262d08 100644 > > > --- a/drivers/clk/qcom/mmcc-msm8974.c > > > +++ b/drivers/clk/qcom/mmcc-msm8974.c > > > @@ -2411,7 +2399,6 @@ static struct clk_regmap *mmcc_msm8974_clocks[] = { > > > [VFE0_CLK_SRC] = &vfe0_clk_src.clkr, > > > [VFE1_CLK_SRC] = &vfe1_clk_src.clkr, > > > [MDP_CLK_SRC] = &mdp_clk_src.clkr, > > > - [GFX3D_CLK_SRC] = &gfx3d_clk_src.clkr, > > > [JPEG0_CLK_SRC] = &jpeg0_clk_src.clkr, > > > [JPEG1_CLK_SRC] = &jpeg1_clk_src.clkr, > > > [JPEG2_CLK_SRC] = &jpeg2_clk_src.clkr, > > > > I just realized that I also need to remove the GFX3D_CLK_SRC #define > > from include/dt-bindings/clock/qcom,mmcc-msm8974.h. I'll send out a v2 > > tomorrow evening. > > > > Please don't change the binding. In reality the define will never be > used but also in reality the clk exists, so it's fine to leave it in the > binding. OK, that makes sense. Thanks for your help on this. Brian