On 15-11-19, 14:21, Takashi Iwai wrote: > On Fri, 15 Nov 2019 11:27:02 +0100, > Vinod Koul wrote: > > > > The current design of sending codec parameters assumes that decoders > > will have parsers so they can parse the encoded stream for parameters > > and configure the decoder. > > > > But this assumption may not be universally true and we know some DSPs > > which do not contain the parsers so additional parameters are required > > to be passed. > > > > So add these parameters starting with FLAC decoder. The size of > > snd_codec_options is still 120 bytes after this change (due to this > > being a union) > > > > I think we should also bump the (minor) version if this proposal is > > acceptable so the userspace can check and populate flac specific structure. > > > > Along, with the core header change, patches are added to support FLAC > > in Qualcomm drivers. This was tested on 96boards db845c > > > > Srinivas Kandagatla (1): > > ASoC: qcom: q6asm: add support to flac config > > > > Vinod Koul (2): > > ALSA: compress: add flac decoder params > > ASoC: qcom: q6asm-dai: add support to flac decoder > > Feel free to take my ACK for ALSA core part: > Acked-by: Takashi Iwai <tiwai@xxxxxxx> Thanks Takashi, should we bump the version for the header to check for. Btw I plan to add other decoders required as well. I have mp3 working without any additional params but rest need additional info Thanks -- ~Vinod
