On Mon, Nov 11, 2019 at 07:51:22AM -0700, Jeffrey Hugo wrote: > On Mon, Nov 11, 2019 at 4:38 AM Brian Masney <masneyb@xxxxxxxxxxxxx> wrote: > > > > On Sun, Nov 10, 2019 at 10:37:33AM -0700, Jeffrey Hugo wrote: > > > On Sun, Nov 10, 2019 at 6:53 AM Brian Masney <masneyb@xxxxxxxxxxxxx> wrote: > > > > > > > > On Fri, Nov 08, 2019 at 07:56:25AM -0700, Jeffrey Hugo wrote: > > > > There's a REG_MDP5_PP_AUTOREFRESH_CONFIG() macro upstream here: > > > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/gpu/drm/msm/disp/mdp5/mdp5.xml.h#n1383 > > > > > > > > I'm not sure what to put in that register but I tried configuring it > > > > with a 1 this way and still have the same issue. > > > > > > > > diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_cmd_encoder.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_cmd_encoder.c > > > > index eeef41fcd4e1..6b9acf68fd2c 100644 > > > > --- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_cmd_encoder.c > > > > +++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_cmd_encoder.c > > > > @@ -80,6 +80,7 @@ static int pingpong_tearcheck_setup(struct drm_encoder *encoder, > > > > mdp5_write(mdp5_kms, REG_MDP5_PP_SYNC_THRESH(pp_id), > > > > MDP5_PP_SYNC_THRESH_START(4) | > > > > MDP5_PP_SYNC_THRESH_CONTINUE(4)); > > > > + mdp5_write(mdp5_kms, REG_MDP5_PP_AUTOREFRESH_CONFIG(pp_id), 1); > > > > > > > > return 0; > > > > } > > > > > > bit 31 is the enable bit (set that to 1), bits 15:0 are the > > > frame_count (how many te events before the MDP sends a frame, I'd > > > recommend set to 1). Then after its programmed, you'll have to flush > > > the config, and probably use a _START to make sure the flush takes > > > effect. > > > > I think that I initially get autorefresh enabled based on your > > description above since the ping pong IRQs occur much more frequently. > > However pretty quickly the error 'dsi_err_worker: status=c' is shown, > > the contents on the screen shift to the right, and the screen no longer > > updates after that. That error decodes to > > DSI_ERR_STATE_DLN0_PHY | DSI_ERR_STATE_FIFO according to dsi_host.c. > > > > Here's the relevant code that I have so far: > > So, Unless I missed it, you haven't disabled using _start when > autorefresh is enabled. If you are using both at the same time, > you'll overload the DSI and get those kinds of errors. That fixed the issue. Just to close out this thread, I submitted a patch with what I have here: https://lore.kernel.org/lkml/20191112104854.20850-1-masneyb@xxxxxxxxxxxxx/T/#u I'll work on async commit support for the MDP5. Thanks Jeff and Rob! Brian
