Hi, On Fri, Sep 13, 2019 at 3:00 PM Lina Iyer <ilina@xxxxxxxxxxxxxx> wrote: > > diff --git a/include/linux/soc/qcom/irq.h b/include/linux/soc/qcom/irq.h > new file mode 100644 > index 0000000..85ac4b6 > --- /dev/null > +++ b/include/linux/soc/qcom/irq.h > @@ -0,0 +1,19 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > + > +#ifndef __QCOM_IRQ_H > +#define __QCOM_IRQ_H > + I happened to be looking at a pile of patches and one of them added: +#include <linux/irqdomain.h> ...right here. If/when you spin your patch, maybe you should too? At the moment the patch I was looking at is at: https://android.googlesource.com/kernel/common/+log/refs/heads/android-mainline-tracking Specifically: https://android.googlesource.com/kernel/common/+/448e2302f82a70f52475b6fc32bbe30301052e6b -Doug