On 29-10-19, 09:06, Sudeep Holla wrote: > On Mon, Oct 28, 2019 at 10:22:24AM -0700, Stephen Boyd wrote: > > Quoting Viresh Kumar (2019-10-17 23:03:45) > > > On 17-10-19, 10:47, Stephen Boyd wrote: > > > > Quoting Amit Kucheria (2019-10-17 05:27:37) > > > > > Initialise the clock drivers on sdm845 and qcs404 in core_initcall so we > > > > > can have earlier access to cpufreq during booting. > > > > > > > > > > Signed-off-by: Amit Kucheria <amit.kucheria@xxxxxxxxxx> > > > > > --- > > > > > > > > Acked-by: Stephen Boyd <sboyd@xxxxxxxxxx> > > > > > > > > Makes me sad again. > > > > > > I am wondering why it makes you sad ? :) > > > > > > > We're playing games with initcall levels :( > > > > +1, which will come back and bite us hard soon :) :) I don't like reordering init calls as well, but only when they are used to avoid issues and probe things in a particular order. While the only thing we are doing here is to get things to probe earlier, which isn't wrong IMO :) Lets see if it bites us anytime soon, I would be surprised really :) -- viresh
