On Tue, Oct 29, 2019 at 09:50:40AM -0700, Stephen Boyd wrote: > Quoting Rajendra Nayak (2019-10-23 02:02:19) > > From: Maulik Shah <mkshah@xxxxxxxxxxxxxx> > > > > Add pdc interrupt controller for sc7180 > > > > Signed-off-by: Maulik Shah <mkshah@xxxxxxxxxxxxxx> > > Signed-off-by: Rajendra Nayak <rnayak@xxxxxxxxxxxxxx> > > --- > > v3: > > Used the qcom,sdm845-pdc compatible for pdc node > > Everything else isn't doing the weird old compatible thing. Why not just > add the new compatible and update the driver? I guess I'll have to go > read the history. Marc Zyngier complained on v2 about the churn from adding compatible strings for identical components, and I kinda see his point. I agree that using the 'sdm845' compatible string for sc7180 is odd too. Maybe we should introduce SoC independent compatible strings for IP blocks that are shared across multiple SoCs? If differentiation is needed SoC specific strings can be added.
