Hi, On Fri, Oct 25, 2019 at 2:23 PM Rob Clark <robdclark@xxxxxxxxx> wrote: > > From: Rob Clark <robdclark@xxxxxxxxxxxx> > > This is unused on cheza. Delete the node to get ride of the reserved- > memory section, and to avoid the driver from attempting to load a zap > shader that doesn't exist every time it powers up the GPU. > > (This also avoids a massive amount of dmesg spam about missing zap fw.) optional nit: maybe when this is applied Bjorn / Andy can put in the actual error message to make this easier to find if anyone is seeing this problem. Specifically: msm ae00000.mdss: [drm:adreno_request_fw] *ERROR* failed to load qcom/a630_zap.mdt: -2 adreno 5000000.gpu: [drm:adreno_zap_shader_load] *ERROR* Unable to load a630_zap.mdt > Signed-off-by: Rob Clark <robdclark@xxxxxxxxxxxx> > Cc: Douglas Anderson <dianders@xxxxxxxxxxxx> > --- > arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi | 2 ++ > arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +- > 2 files changed, 3 insertions(+), 1 deletion(-) I probably would have put it in two patches (one for sdm845.dtsi and one for cheza) but that's more because I'm obsessive-compulsive than for any real reason. ;-) In any case: Fixes: 3fdeaee951aa ("arm64: dts: sdm845: Add zap shader region for GPU") Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx> Tested-by: Douglas Anderson <dianders@xxxxxxxxxxxx> -Doug