Hi, On 17/10/2019 20:26:10+0800, YueHaibing wrote: > devm_platform_ioremap_resource() internally have platform_get_resource() > and devm_ioremap_resource() in it. So instead of calling them separately > use devm_platform_ioremap_resource() directly. > Shouldn't we stop with this insanity? The net gain is exactly 2 lines per driver and this puts the full review load on the maintainers. We end up with crap like: https://lore.kernel.org/lkml/9bbcce19c777583815c92ce3c2ff2586@xxxxxxxxxxx/ What is the end goal here ? platform_get_resource and devm_ioremap_resource will have to stay even after you have done the conversion. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
