Hi Rob, Thanks for the review On 09/30/2019 10:42 AM, Rob Herring wrote: > On Tue, Sep 10, 2019 at 01:14:34PM -0400, Thara Gopinath wrote: >> Add binding to define power domains as thermal warming >> devices. >> >> Signed-off-by: Thara Gopinath <thara.gopinath@xxxxxxxxxx> >> --- >> .../bindings/thermal/pwr-domain-warming.txt | 32 ++++++++++++++++++++++ >> 1 file changed, 32 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/thermal/pwr-domain-warming.txt >> >> diff --git a/Documentation/devicetree/bindings/thermal/pwr-domain-warming.txt b/Documentation/devicetree/bindings/thermal/pwr-domain-warming.txt >> new file mode 100644 >> index 0000000..25fc568 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/thermal/pwr-domain-warming.txt >> @@ -0,0 +1,32 @@ >> +* Generic power domain based thermal warming device. >> + >> +This binding describes the power domains that can be used as a >> +thermal warming device. > > This looks like just a gathering of properties and way to instantiate > some driver. > > I think this all belongs in the power domain provider. Make it a cooling > device and you should know which domains are relevant based on the > compatible (though perhaps we could consider a list in DT). If you want > to instantiate a separate driver to handle this, then make the power > domain driver do that. This sounds fine. A list in DT might be needed though. I have a separate driver. I should be able to get the genpd provider driver call into it. I had asked this to Ulf and he seemed to be fine with it as well > > Rob > > -- Regards Thara
