Quoting Amit Kucheria (2019-09-20 14:52:29) > Hide the details of how to convert values read from TSENS HW to mCelsius > behind a function. All versions of the IP can be supported as a result. > > Signed-off-by: Amit Kucheria <amit.kucheria@xxxxxxxxxx> > --- Reviewed-by: Stephen Boyd <swboyd@xxxxxxxxxxxx> Just one nit below. > drivers/thermal/qcom/tsens-common.c | 50 +++++++++++++++++++++-------- > 1 file changed, 36 insertions(+), 14 deletions(-) > > diff --git a/drivers/thermal/qcom/tsens-common.c b/drivers/thermal/qcom/tsens-common.c > index ea2c46cc6a66..6b6b3841c2d0 100644 > --- a/drivers/thermal/qcom/tsens-common.c > +++ b/drivers/thermal/qcom/tsens-common.c > @@ -310,6 +331,7 @@ int __init init_common(struct tsens_priv *priv) > goto err_put_device; > } > } > + > for (i = 0, j = VALID_0; i < priv->feat->max_sensors; i++, j++) { > priv->rf[j] = devm_regmap_field_alloc(dev, priv->tm_map, > priv->fields[j]); Drop this hunk?