On Tue, 2019-09-17 at 14:48 +0530, Amit Kucheria wrote: > On Tue, Sep 17, 2019 at 1:30 AM Daniel Lezcano > <daniel.lezcano@xxxxxxxxxx> wrote: > > > > On 12/09/2019 00:32, Amit Kucheria wrote: > > > From: Lina Iyer <ilina@xxxxxxxxxxxxxx> > > > > > > Now that the thermal framework is built-in, in order to > > > facilitate > > > thermal mitigation as early as possible in the boot cycle, move > > > the > > > thermal framework initialization to core_initcall. > > > > > > However, netlink initialization happens only as part of > > > subsys_initcall. > > > At this time in the boot process, the userspace is not available > > > yet. So > > > initialize the netlink events later in fs_initcall. > > > > Why not kill directly the netlink part, no one is using it in the > > kernel? > > That's a good point. I wasn't sure if anybody was using it, but I can > remove it completely since no driver seems to be using the > thermal_generate_netlink_event() api. Interesting, I recalled that thermal_generate_netlink_event() is indeed used by some thermal driver, but it's true that no one is using it now. let's remove it and see if we get any complains. thanks, rui > > Regards, > Amit > > $ git grep thermal_generate_netlink_event > Documentation/thermal/sysfs-api.rst:just need to call > thermal_generate_netlink_event() with two arguments viz > drivers/thermal/thermal_core.c:int > thermal_generate_netlink_event(struct thermal_zone_device *tz, > drivers/thermal/thermal_core.c:EXPORT_SYMBOL_GPL(thermal_generate_net > link_event); > include/linux/thermal.h:extern int > thermal_generate_netlink_event(struct thermal_zone_device *tz, > include/linux/thermal.h:static inline int > thermal_generate_netlink_event(struct thermal_zone_device *tz,
