Hi Stephen,
On 2019-09-06 20:37, Stephen Boyd wrote:
Quoting Vivek Gautam (2019-08-22 23:32:48)
diff --git a/drivers/iommu/arm-smmu-impl.c
b/drivers/iommu/arm-smmu-impl.c
index 3f88cd078dd5..0aef87c41f9c 100644
--- a/drivers/iommu/arm-smmu-impl.c
+++ b/drivers/iommu/arm-smmu-impl.c
@@ -102,7 +103,6 @@ static struct arm_smmu_device
*cavium_smmu_impl_init(struct arm_smmu_device *smm
return &cs->smmu;
}
-
#define ARM_MMU500_ACTLR_CPRE (1 << 1)
#define ARM_MMU500_ACR_CACHE_LOCK (1 << 26)
Drop this hunk?
@@ -147,6 +147,28 @@ static const struct arm_smmu_impl arm_mmu500_impl
= {
.reset = arm_mmu500_reset,
};
+static int qcom_sdm845_smmu500_reset(struct arm_smmu_device *smmu)
+{
+ int ret;
+
+ arm_mmu500_reset(smmu);
+
+ /*
+ * To address performance degradation in non-real time
clients,
+ * such as USB and UFS, turn off wait-for-safe on sdm845 based
boards,
+ * such as MTP and db845, whose firmwares implement secure
monitor
+ * call handlers to turn on/off the wait-for-safe logic.
+ */
+ ret = qcom_scm_qsmmu500_wait_safe_toggle(0);
+ if (ret)
+ dev_warn(smmu->dev, "Failed to turn off SAFE
logic\n");
+
+ return 0;
return ret? Or intentionally don't return an error for failure?
+}
+
+const struct arm_smmu_impl qcom_sdm845_smmu500_impl = {
static?
+ .reset = qcom_sdm845_smmu500_reset,
+};
struct arm_smmu_device *arm_smmu_impl_init(struct arm_smmu_device
*smmu)
{
Have addressed all your comments in v5.
Thanks,
Sai
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a
member
of Code Aurora Forum, hosted by The Linux Foundation
