On Wed, Sep 4, 2019 at 6:05 PM YueHaibing <yuehaibing@xxxxxxxxxx> wrote: > > Use devm_platform_ioremap_resource() to simplify the code a bit. > This is detected by coccinelle. > > Reported-by: Hulk Robot <hulkci@xxxxxxxxxx> > Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx> Acked-by: Amit Kucheria <amit.kucheria@xxxxxxxxxx> > --- > drivers/thermal/qcom/tsens-common.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/thermal/qcom/tsens-common.c b/drivers/thermal/qcom/tsens-common.c > index 528df88..43ce4fb 100644 > --- a/drivers/thermal/qcom/tsens-common.c > +++ b/drivers/thermal/qcom/tsens-common.c > @@ -155,7 +155,6 @@ int __init init_common(struct tsens_priv *priv) > { > void __iomem *tm_base, *srot_base; > struct device *dev = priv->dev; > - struct resource *res; > u32 enabled; > int ret, i, j; > struct platform_device *op = of_find_device_by_node(priv->dev->of_node); > @@ -166,8 +165,7 @@ int __init init_common(struct tsens_priv *priv) > if (op->num_resources > 1) { > /* DT with separate SROT and TM address space */ > priv->tm_offset = 0; > - res = platform_get_resource(op, IORESOURCE_MEM, 1); > - srot_base = devm_ioremap_resource(&op->dev, res); > + srot_base = devm_platform_ioremap_resource(op, 1); > if (IS_ERR(srot_base)) { > ret = PTR_ERR(srot_base); > goto err_put_device; > @@ -184,8 +182,7 @@ int __init init_common(struct tsens_priv *priv) > priv->tm_offset = 0x1000; > } > > - res = platform_get_resource(op, IORESOURCE_MEM, 0); > - tm_base = devm_ioremap_resource(&op->dev, res); > + tm_base = devm_platform_ioremap_resource(op, 0); > if (IS_ERR(tm_base)) { > ret = PTR_ERR(tm_base); > goto err_put_device; > -- > 2.7.4 > >