On Thu, Aug 15, 2019 at 10:22:45AM +0200, Linus Walleij wrote:
> On Thu, Aug 15, 2019 at 2:49 AM Brian Masney <masneyb@xxxxxxxxxxxxx> wrote:
>
> > Add support for the avdd33 regulator to the analogix-anx78xx driver.
> > Note that the regulator is currently enabled during driver probe and
> > disabled when the driver is removed. This is currently how the
> > downstream MSM kernel sources do this.
> >
> > Let's not merge this upstream for the mean time until I get the external
> > display fully working on the Nexus 5 and then I can submit proper
> > support then that powers down this regulator in the power off function.
> >
> > Signed-off-by: Brian Masney <masneyb@xxxxxxxxxxxxx>
>
> > +static void anx78xx_disable_regulator_action(void *_data)
> > +{
> > + struct anx78xx_platform_data *pdata = _data;
> > +
> > + regulator_disable(pdata->avdd33);
> > +}
> (...)
> > + err = devm_add_action(dev, anx78xx_disable_regulator_action,
> > + pdata);
>
> Clever idea. Good for initial support, probably later on it would
> need to be reworked using runtime PM so it's not constantly
> powered up.
Yes, that's my plan. I suspect that I may have a regulator disabled
somewhere so I was planning to leave this on all the time for the time
being to match the downstream behavior until I get the hot plug detect
GPIO working.
> Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
Thanks,
Brian
