Re: [PATCH] phy: qualcomm: phy-qcom-qmp: Add of_node_put() before return

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c
> @@ -2094,6 +2094,7 @@ static int qcom_qmp_phy_probe(struct platform_device *pdev)
>  			dev_err(dev, "failed to create lane%d phy, %d\n",
>  				id, ret);
>  			pm_runtime_disable(dev);
> +			of_node_put(child);
>  			return ret;
>  		}

I suggest to move a bit of common exception handling code to the end of
this function implementation.
Would you like to add a jump target?

Regards,
Markus



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux