Thanks for the review Amit!
On 30-07-19, 22:05, Amit Kucheria wrote:
> On Thu, Jul 25, 2019 at 7:23 PM Vinod Koul <vkoul@xxxxxxxxxx> wrote:
> >
> > The adc nodes have reg property but were missing the unit name, so add
> > that to fix these warnings:
> >
> > arch/arm64/boot/dts/qcom/pms405.dtsi:91.12-94.6: Warning (unit_address_vs_reg): /soc@0/spmi@200f000/pms405@0/adc@3100/ref_gnd: node has a reg or ranges property, but no unit name
> > arch/arm64/boot/dts/qcom/pms405.dtsi:96.14-99.6: Warning (unit_address_vs_reg): /soc@0/spmi@200f000/pms405@0/adc@3100/vref_1p25: node has a reg or ranges property, but no unit name
> > arch/arm64/boot/dts/qcom/pms405.dtsi:101.19-104.6: Warning (unit_address_vs_reg): /soc@0/spmi@200f000/pms405@0/adc@3100/vph_pwr: node has a reg or ranges property, but no unit name
> > arch/arm64/boot/dts/qcom/pms405.dtsi:106.13-109.6: Warning (unit_address_vs_reg): /soc@0/spmi@200f000/pms405@0/adc@3100/die_temp: node has a reg or ranges property, but no unit name
> > arch/arm64/boot/dts/qcom/pms405.dtsi:111.27-116.6: Warning (unit_address_vs_reg): /soc@0/spmi@200f000/pms405@0/adc@3100/thermistor1: node has a reg or ranges property, but no unit name
> > arch/arm64/boot/dts/qcom/pms405.dtsi:118.27-123.6: Warning (unit_address_vs_reg): /soc@0/spmi@200f000/pms405@0/adc@3100/thermistor3: node has a reg or ranges property, but no unit name
> > arch/arm64/boot/dts/qcom/pms405.dtsi:125.22-130.6: Warning (unit_address_vs_reg): /soc@0/spmi@200f000/pms405@0/adc@3100/xo_temp: node has a reg or ranges property, but no unit name
> >
> > Signed-off-by: Vinod Koul <vkoul@xxxxxxxxxx>
> > ---
> > arch/arm64/boot/dts/qcom/pms405.dtsi | 14 +++++++-------
> > 1 file changed, 7 insertions(+), 7 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/pms405.dtsi b/arch/arm64/boot/dts/qcom/pms405.dtsi
> > index 14240fedd916..3c10cf04d26e 100644
> > --- a/arch/arm64/boot/dts/qcom/pms405.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/pms405.dtsi
> > @@ -88,41 +88,41 @@
> > #size-cells = <0>;
> > #io-channel-cells = <1>;
> >
> > - ref_gnd {
> > + ref_gnd@0 {
> > reg = <ADC5_REF_GND>;
> > qcom,pre-scaling = <1 1>;
> > };
> >
> > - vref_1p25 {
> > + vref_1p25@1 {
> > reg = <ADC5_1P25VREF>;
> > qcom,pre-scaling = <1 1>;
> > };
> >
> > - pon_1: vph_pwr {
> > + pon_1: vph_pwr@131 {
> > reg = <ADC5_VPH_PWR>;
> > qcom,pre-scaling = <1 3>;
> > };
> >
> > - die_temp {
> > + die_temp@6 {
> > reg = <ADC5_DIE_TEMP>;
> > qcom,pre-scaling = <1 1>;
> > };
> >
> > - pa_therm1: thermistor1 {
> > + pa_therm1: thermistor1@115 {
>
> s/115/77 ?
>
> > reg = <ADC5_AMUX_THM1_100K_PU>;
> > qcom,ratiometric;
> > qcom,hw-settle-time = <200>;
> > qcom,pre-scaling = <1 1>;
> > };
> >
> > - pa_therm3: thermistor3 {
> > + pa_therm3: thermistor3@117 {
>
> s/117/79 ?
>
> > reg = <ADC5_AMUX_THM3_100K_PU>;
> > qcom,ratiometric;
> > qcom,hw-settle-time = <200>;
> > qcom,pre-scaling = <1 1>;
> > };
> >
> > - xo_therm: xo_temp {
> > + xo_therm: xo_temp@114 {
>
> s/114/76 ?
Thanks, will fix these and recheck others.
--
~Vinod
