On Sun, Jul 28, 2019 at 08:57:50AM +0800, xiaofeis wrote: > Set phy device advertising to enable MAC flow control. Hi Xiaofei. This is half of the needed change for MAC flow control. phy_support_asym_pause(phy) is used by the MAC to tell the PHY layer that the MAC supports flow control. The PHY will then advertise this. When auto-negotiation is completed, the PHY layer will call qca8k_adjust_link() with the results. It could be that the peer does not support flow control, or only supports symmetric flow control. So in that function, you need to program the MAC with the results of the auto-neg. This is currently missing. You need to look at phydev->pause and phydev->asym_pause to decide how to configure the MAC. Andrew