Quoting Govind Singh (2019-07-26 02:23:27) > Add devicetree binding for the Q6SSTOP clock controller found in QCS404. > > Signed-off-by: Govind Singh <govinds@xxxxxxxxxxxxxx> If this patch goes again, please convert to YAML. > --- > .../bindings/clock/qcom,q6sstopcc.txt | 26 +++++++++++++++++++ > 1 file changed, 26 insertions(+) > create mode 100755 Documentation/devicetree/bindings/clock/qcom,q6sstopcc.txt > > diff --git a/Documentation/devicetree/bindings/clock/qcom,q6sstopcc.txt b/Documentation/devicetree/bindings/clock/qcom,q6sstopcc.txt > new file mode 100755 > index 000000000000..157bb52f9dc4 > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/qcom,q6sstopcc.txt > @@ -0,0 +1,26 @@ > +Qualcomm Q6SSTOP Clock Controller Binding > +----------------------------------------------- > + > +Required properties : > +- compatible : shall contain "qcom,qcs404-q6sstopcc" > +- #clock-cells : from common clock binding, shall contain 1 > +- reg : shall contain base register address and size, > + in the order > + Index 0 maps to Q6SSTOP clocks register region > + Index 1 maps to Q6SSTOP_TCSR register region > + > +Optional properties : > +- reg-names : register names of WCSS domain > + "q6sstop_cc", "q6sstop_tcsr". > + > +Example: > +The below node has to be defined in the cases where the WCSS peripheral loader > +would bring the subsystem out of reset. > + > + q6sstopcc: clock-controller@7500000 { > + compatible = "qcom,qcs404-q6sstopcc"; > + reg = <0x7500000 0x4e000>, <0x7550000 0x10000>; > + reg-names = "q6sstop_cc", "q6sstop_tcsr"; > + clocks = <&gcc GCC_WCSS_Q6_AHB_CLK>; This isn't described in the binding. Are there clocks that go here? Please add them to the binding.