On Fri, Jul 19, 2019 at 10:53:11AM +0800, xiaofeis wrote: > Set phy device advertising to enable MAC flow control. > > Change-Id: Ibf0f554b072fc73136ec9f7ffb90c20b25a4faae > Signed-off-by: Xiaofei Shen <xiaofeis@xxxxxxxxxxxxxx> > --- > drivers/net/dsa/qca8k.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/dsa/qca8k.c b/drivers/net/dsa/qca8k.c > index d93be14..95ac081 100644 > --- a/drivers/net/dsa/qca8k.c > +++ b/drivers/net/dsa/qca8k.c > @@ -1,7 +1,7 @@ > /* > * Copyright (C) 2009 Felix Fietkau <nbd@xxxxxxxx> > * Copyright (C) 2011-2012 Gabor Juhos <juhosg@xxxxxxxxxxx> > - * Copyright (c) 2015, The Linux Foundation. All rights reserved. > + * Copyright (c) 2015, 2019, The Linux Foundation. All rights reserved. > * Copyright (c) 2016 John Crispin <john@xxxxxxxxxxx> > * > * This program is free software; you can redistribute it and/or modify > @@ -800,6 +800,8 @@ > qca8k_port_set_status(priv, port, 1); > priv->port_sts[port].enabled = 1; > > + phy->advertising |= (ADVERTISED_Pause | ADVERTISED_Asym_Pause); Drop the unnecessary parentheses. Question for DSA maintainers: shouldn't this be implemented in the dsa_switch_ops phylink_validate callback, like it's done for other dsa drivers? Kind regards, Niklas > + > return 0; > } > > -- > 1.9.1 >
