Quoting Taniya Das (2019-05-12 20:44:46) > On 5/10/2019 11:24 PM, Stephen Boyd wrote: > >>>> diff --git a/drivers/clk/qcom/clk-rcg.h b/drivers/clk/qcom/clk-rcg.h > >>>> index 5562f38..e40e8f8 100644 > >>>> --- a/drivers/clk/qcom/clk-rcg.h > >>>> +++ b/drivers/clk/qcom/clk-rcg.h > >>>> @@ -171,7 +171,7 @@ struct clk_rcg_dfs_data { > >>>> }; > >>>> > >>>> #define DEFINE_RCG_DFS(r) \ > >>>> - { .rcg = &r##_src, .init = &r##_init } > >>>> + { .rcg = &r, .init = &r##_init } > >>> > >>> Why do we need to rename the init data? > >>> > >> > >> We want to manage the init data as the clock source name, so that we > >> could manage to auto generate our code. So that we do not have to > >> re-name the clock init data manually if the DFS source names gets > >> updated at any point of time. > >> > > > > Why is the clk name changing to not have a _src after the "root" of the > > clk name? As long as I can remember, RCGs have a "_src" postfix. > > > > Yes, the RCGs would have _src, so we do want the init data also to be > generated with _src postfix. So that we do not have to manually clean up > the generated code. > Please manually cleanup the generated code, or fix the code generator to do what you want.