On Fri, Jul 12, 2019 at 7:22 AM Jeffrey Hugo <jeffrey.l.hugo@xxxxxxxxx> wrote: > > On Fri, Jul 12, 2019 at 7:01 AM Andrzej Hajda <a.hajda@xxxxxxxxxxx> wrote: > > > > On 11.07.2019 15:56, Rob Clark wrote: > > > On Thu, Jul 11, 2019 at 6:11 AM Andrzej Hajda <a.hajda@xxxxxxxxxxx> wrote: > > >> On 06.07.2019 03:06, Mark Brown wrote: > > >>> On Wed, Jul 03, 2019 at 02:45:12PM -0700, Jeffrey Hugo wrote: > > >>>> Add basic support with a simple implementation that utilizes the generic > > >>>> read/write commands to allow device registers to be configured. > > >>> This looks good to me but I really don't know anything about DSI, > > >>> I'd appreciate some review from other people who do. I take it > > >>> there's some spec thing in DSI that says registers and bytes must > > >>> both be 8 bit? > > >> > > >> I am little bit confused about regmap usage here. On the one hand it > > >> nicely fits to this specific driver, probably because it already uses > > >> regmap_i2c. > > >> > > >> On the other it will be unusable for almost all current DSI drivers and > > >> probably for most new drivers. Why? > > >> > > >> 1. DSI protocol defines actually more than 30 types of transactions[1], > > >> but this patchset implements only few of them (dsi generic write/read > > >> family). Is it possible to implement multiple types of transactions in > > >> regmap? > > >> > > >> 2. There is already some set of helpers which uses dsi bus, rewriting it > > >> on regmap is possible or driver could use of regmap and direct access > > >> together, the question is if it is really necessary. > > >> > > >> 3. DSI devices are no MFDs so regmap abstraction has no big value added > > >> (correct me, if there are other significant benefits). > > >> > > > I assume it is not *just* this one bridge that can be programmed over > > > either i2c or dsi, depending on how things are wired up on the board. > > > It certainly would be nice for regmap to support this case, so we > > > don't have to write two different bridge drivers for the same bridge. > > > I wouldn't expect a panel that is only programmed via dsi to use this. > > > > > > On the other side supporting DSI and I2C in one driver is simply matter > > of writing proper accesors. > > To me, this reads like your counter argument to not using regmap, is > to reinvent regmap. Maybe I don't understand what you are proposing > here, but it sounds like remove the regmap support, define sn65 > specific accessors that just before sending the write to the bus does > a check if the access needs to go over i2c or DSI. Feels like a > clunky version of regmap to me. Why not use the existing "generic" > framework? > > To your point that DSI defines over 30 message types, yes it does, but > that seems to be outside of the scope. How many of those are actually > for doing register access? I'm thinking just 4 (technically a hair > more than that because of the multiple version of the same message) - > generic read, generic write, dcs read, dcs write. I don't view regmap > as a generic abstraction layer over a particular mechanism, and thus > needs to support everything that mechanism does. Sending sync > commands, or pixel data over DSI is outside the scope of regmap to me. I'm w/ jhugo on this one.. if you are working w/ a device that can be programmed via i2c or dsi, regmap and limiting yourself to the small subset of dsi cmds which map to i2c reads/writes, makes a ton of sense. (And I'm almost certain this bridge isn't the only such device.) That isn't to say you should use regmap for devices that are only programmed over dsi. That would be silly. The original argument about this not being usable by most DSI devices is really a non-sequitur. BR, -R
