On Thu, Jun 27, 2019 at 12:21:39PM +1000, Dave Airlie wrote:
> On Wed, 26 Jun 2019 at 08:34, Rob Clark <robdclark@xxxxxxxxx> wrote:
> >
> > Hi Dave,
> >
>
> Naughty naughty rebase.
>
> dim: f47bee2ba447 ("drm/msm/a3xx: remove TPL1 regs from snapshot"):
> Subject in fixes line doesn't match referenced commit:
> dim: 7198e6b03155 drm/msm: add a3xx gpu support
> dim: fc19cbb785d7 ("drm/msm/mdp5: Fix mdp5_cfg_init error return"):
> Subject in fixes line doesn't match referenced commit:
> dim: 2e362e1772b8 (drm/msm/mdp5: introduce mdp5_cfg module)
Hi Dave,
Was chatting with Rob about this on IRC and these failures aren't due to a
rebase (we were quite careful to avoid rebasing this cycle). The issue seems to
be that the commit messages use the format,
Fixes: <hash> <subject>
for Fixes tags and dim does this when comparing the subject:
if [[ "$fixes_subject" != "(\"$orig_subject\")" ]] ; then
So dim is being quite strict about adding parens and quotations to the subject
in fixes lines and failing as a result.
IMO since the hashes are correct this formatting should be fine.
Ok with you?
Sean
PS- If it's fine to format like this, we might want to change the dim check to
something like:
if [[ "$orig_subject" != *"$fixes_subject"* ]] ; then
>
> Please fix or squash those and resend.
>
> Dave.
> _______________________________________________
> Freedreno mailing list
> Freedreno@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/freedreno
--
Sean Paul, Software Engineer, Google / Chromium OS
