On Tue, Jun 25, 2019 at 12:29 PM Neeraj Upadhyay <neeraju@xxxxxxxxxxxxxx> wrote: > On 6/25/19 2:28 PM, Linus Walleij wrote: > > Please don't name functions __like __that. > > > >> -static void msm_gpio_irq_unmask(struct irq_data *d) > >> +static void __msm_gpio_irq_unmask(struct irq_data *d, bool status_clear) > > Instead of __unclear __underscore __semantic use something > > really descriptive like > > > > static void msm_gpio_irq_clear_irq() > > > > That is what it does, right? > > Is below ok? as it clears (if status_clear set) and then unmasks irq > > static void msm_gpio_irq_clear_unmask() Sure thing! Thanks. Yours, Linus Walleij
