On 21-06-19, 21:59, Christian Lamparter wrote: > On Friday, June 21, 2019 10:59:09 AM CEST Vinod Koul wrote: > > + /* > > + * The Firmware's Data Format is describe in > > + * "6.3 Data Format" R19UH0078EJ0500 Rev.5.00 page 124 > > + */ > > + > > + /* "Each row is 8 bytes". => firmware size must be a multiple of 8. */ > > + if (length % 8 != 0) > > + dev_warn(&dev->dev, "firmware size is not a multiple of 8."); > > It doesn't look like this holds true for the newer K2026090.mem which > arguably fixes a lot of bugs over K2013080.mem. I think we should remove > this check and message. The documentation still says so, that is why I changed error return and this to warning. Yeah lets remove to not confuse folks :) -- ~Vinod
