On 6/20/2019 3:38 PM, Suzuki K Poulose wrote:
Hi Sai,
On 20/06/2019 10:51, Sai Prakash Ranjan wrote:
...
diff --git a/drivers/hwtracing/coresight/coresight-etm4x.c
b/drivers/hwtracing/coresight/coresight-etm4x.c
index 8bb0092c7ec2..660432acbac0 100644
--- a/drivers/hwtracing/coresight/coresight-etm4x.c
+++ b/drivers/hwtracing/coresight/coresight-etm4x.c
@@ -1107,7 +1107,10 @@ static int etm4_probe(struct amba_device *adev,
const struct amba_id *id)
spin_lock_init(&drvdata->spinlock);
- drvdata->cpu = pdata ? pdata->cpu : 0;
I believe, we should simply abort when we don't have pdata. There is no
point
in registering this ETM unless we know where this is connected to.
I did not understand this comment since I am returning with ENODEV here
and not registering this ETM.
I meant,
/* fail the probe, as we don't know where this is connected to */
if (pdata)
return -ENOENT;
Cheers
Suzuki
Thanks Suzuki, got it :)
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
