On Tue 18 Jun 00:39 PDT 2019, Marc Gonzalez wrote:
> On 18/06/2019 07:24, Bjorn Andersson wrote:
>
> > Node names shouldn't include "qcom," and should whenever possible use
> > a generic identifier. Resolve this by renaming the smmu nodes "iommu".
>
> You mention "qcom" here, but the prefix you changed is "arm"
> /me confused ^_^
>
Thanks for proof reading my patches Marc
I'll respin this.
Regards,
Bjorn
>
> > arch/arm64/boot/dts/qcom/msm8996.dtsi | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> > index 2ecd9d775d61..c934e00434c7 100644
> > --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> > @@ -1163,7 +1163,7 @@
> > };
> > };
> >
> > - vfe_smmu: arm,smmu@da0000 {
> > + vfe_smmu: iommu@da0000 {
> > compatible = "qcom,msm8996-smmu-v2", "qcom,smmu-v2";
> > reg = <0xda0000 0x10000>;
> >
> > @@ -1314,7 +1314,7 @@
> > };
> > };
> >
> > - adreno_smmu: arm,smmu@b40000 {
> > + adreno_smmu: iommu@b40000 {
> > compatible = "qcom,msm8996-smmu-v2", "qcom,smmu-v2";
> > reg = <0xb40000 0x10000>;
> >
> > @@ -1331,7 +1331,7 @@
> > power-domains = <&mmcc GPU_GDSC>;
> > };
> >
> > - mdp_smmu: arm,smmu@d00000 {
> > + mdp_smmu: iommu@d00000 {
> > compatible = "qcom,msm8996-smmu-v2", "qcom,smmu-v2";
> > reg = <0xd00000 0x10000>;
> >
> > @@ -1347,7 +1347,7 @@
> > power-domains = <&mmcc MDSS_GDSC>;
> > };
> >
> > - lpass_q6_smmu: arm,smmu-lpass_q6@1600000 {
> > + lpass_q6_smmu: iommu@1600000 {
> > compatible = "qcom,msm8996-smmu-v2", "qcom,smmu-v2";
> > reg = <0x1600000 0x20000>;
> > #iommu-cells = <1>;
> >
