On Tue, May 28, 2019 at 8:06 PM Eduardo Valentin <edubezval@xxxxxxxxx> wrote: > > Hello, > > On Tue, May 28, 2019 at 04:37:15PM -0500, Andy Gross wrote: > > +Eduardo > > > > On Tue, May 28, 2019 at 1:09 PM Andy Gross <andygro@xxxxxxxxx> wrote: > > > > > On Sun, May 26, 2019 at 4:51 PM Amit Kucheria <amit.kucheria@xxxxxxxxxx> > > > wrote: > > > > > > <snip> > > > > > > > Sorry for breaking the boot on 8064. That was one of the platforms > > > > that I didn't convert over to regmap (needs more refactoring). I had > > > > hoped kernelci would catch any issues but looks like thermal-soc tree > > > > entered linux-next quite late and didn't catch this. > > > > > > > > Does reverting 3e6a8fb33084 ("drivers: thermal: tsens: Add new > > > > operation to check if a sensor is enabled") fix the issue? If so, > > > > reverting that commit might be the best course of action since I've > > > > started vacations and can't fix this for 8064 in a meaningful amount > > > > of time (until 3rd week of June). cc'ing Bjorn in case this needs more > > > > investigation, but I think that patch is fairly self contained and > > > > reverting it shouldn't have any knock-on effects. > > > > > > I am ok with this. I'll check with Bjorn before adding this to a > > > fixes for -rc2. > > > > > > > Eduardo, we have a situation with the Qcom tsens driver and > > commit 3e6a8fb33084. Do you mind if I send in a revert for this through > > my tree or can you do this for us for -rc2? > > I can revert this patch. I can confirm that it is selfcontained and > reverting seams to work. I am sending the revert to -rc3, as rc2 is > already out. Perfect. Thanks Eduardo! Andy