Hi, On Thu, May 9, 2019 at 11:44 AM Rob Clark <robdclark@xxxxxxxxx> wrote: > From: Douglas Anderson <dianders@xxxxxxxxxxxx> > > Let's fixup the reserved memory to re-add the things we deleted in > ("CHROMIUM: arm64: dts: qcom: sdm845-cheza: Temporarily delete > reserved-mem changes") in a way that plays nicely with the new > upstream definitions. The message above makes no sense since that commit you reference isn't in upstream. ...but in any case, why not squash this in with the previous commit? > Signed-off-by: Douglas Anderson <dianders@xxxxxxxxxxxx> > Reviewed-by: Stephen Boyd <swboyd@xxxxxxxxxxxx> > Signed-off-by: Rob Clark <robdclark@xxxxxxxxxxxx> Remove Stephen's Reviewed-by. In general reviews that happen in the Chrome OS gerrit shouldn't be carried over when things are posted upstream. > +/* Increase the size from 2MB to 8MB */ > +&rmtfs_mem { > + reg = <0 0x88f00000 0 0x800000>; > +}; > + > +/ { > + reserved-memory { > + venus_mem: memory@96000000 { > + reg = <0 0x96000000 0 0x500000>; > + no-map; > + }; > + }; > +}; nit: blank line? -Doug