From: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
Date: Tue, 7 May 2019 23:06:40 -0700
> +static void qrtr_tx_resume(struct qrtr_node *node, struct sk_buff *skb)
> +{
> + struct qrtr_ctrl_pkt *pkt = (struct qrtr_ctrl_pkt *)skb->data;
> + struct qrtr_tx_flow *flow;
> + unsigned long key;
> + u64 remote_node = le32_to_cpu(pkt->client.node);
> + u32 remote_port = le32_to_cpu(pkt->client.port);
Reverse christmas tree for the local variables please.
> +static int qrtr_tx_wait(struct qrtr_node *node, int dest_node, int dest_port,
> + int type)
> +{
> + struct qrtr_tx_flow *flow;
> + unsigned long key = (u64)dest_node << 32 | dest_port;
> + int confirm_rx = 0;
> + int ret;
Likewise.
> /* Pass an outgoing packet socket buffer to the endpoint driver. */
> static int qrtr_node_enqueue(struct qrtr_node *node, struct sk_buff *skb,
> int type, struct sockaddr_qrtr *from,
> struct sockaddr_qrtr *to)
> {
> struct qrtr_hdr_v1 *hdr;
> + int confirm_rx;
> size_t len = skb->len;
> int rc = -ENODEV;
Likewise.
