On Thu, Apr 25, 2019 at 02:43:56PM +0200, Marcel Holtmann wrote: > Hi Harish, > > > Add compatible string for the Qualcomm WCN3998 Bluetooth controller > > > > Signed-off-by: Harish Bandi <c-hbandi@xxxxxxxxxxxxxx> > > --- > > Changes in V6: > > - Changed Commit text > > --- > > Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt > > index 824c0e2..7ef6118 100644 > > --- a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt > > +++ b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt > > @@ -11,20 +11,21 @@ Required properties: > > - compatible: should contain one of the following: > > * "qcom,qca6174-bt" > > * "qcom,wcn3990-bt" > > + * "qcom,wcn3998-bt" > > > > Optional properties for compatible string qcom,qca6174-bt: > > > > - enable-gpios: gpio specifier used to enable chip > > - clocks: clock provided to the controller (SUSCLK_32KHZ) > > > > -Required properties for compatible string qcom,wcn3990-bt: > > +Required properties for compatible string qcom,wcn399x-bt: > > > > - vddio-supply: VDD_IO supply regulator handle. > > - vddxo-supply: VDD_XO supply regulator handle. > > - vddrf-supply: VDD_RF supply regulator handle. > > - vddch0-supply: VDD_CH0 supply regulator handle. > > > > -Optional properties for compatible string qcom,wcn3990-bt: > > +Optional properties for compatible string qcom,wcn399x-bt: > > wasn’t the conclusion to _not_ use x things in compatible strings? I would personally prefer you list these two compatible strings separately. However I let Rob comment and Ack this if this is fine for him. It's fine for me as it isn't the actual string used. Reviewed-by: Rob Herring <robh@xxxxxxxxxx> Rob
