On Mon, Apr 22, 2019 at 03:15:32PM +0530, Vinod Koul wrote: > stmmac_check_ether_addr() checks the MAC address and assigns one in > driver open(). In many cases when we create slave netdevice, the dev > addr is inherited from master but the master dev addr maybe NULL at > that time, so move this call to driver probe so that address is > always valid. > > Signed-off-by: Xiaofei Shen <xiaofeis@xxxxxxxxxxxxxx> > Tested-by: Xiaofei Shen <xiaofeis@xxxxxxxxxxxxxx> > Signed-off-by: Sneh Shah <snehshah@xxxxxxxxxxxxxx> > Signed-off-by: Vinod Koul <vkoul@xxxxxxxxxx> Thanks for doing it this way. Reviewed-by: Andrew Lunn <andrew@xxxxxxx> Andrew