On 09/04/2019 14:48, Marc Gonzalez wrote: > Documentation for this PHY, and the proper configuration settings, > is *not* publicly available. Therefore the initialization sequence > is copied wholesale from downstream: > > https://source.codeaurora.org/quic/la/kernel/msm-4.4/tree/arch/arm/boot/dts/qcom/msm8998-v2.dtsi?h=LE.UM.1.3.r3.25#n372 > > Reviewed-by: Vivek Gautam <vivek.gautam@xxxxxxxxxxxxxx> > Signed-off-by: Marc Gonzalez <marc.w.gonzalez@xxxxxxx> > --- > Changes from v3: Rewrite commit log to make it clear that I didn't have access > to any docs, and just copied the downstream code. > --- > drivers/phy/qualcomm/phy-qcom-qmp.c | 110 ++++++++++++++++++++++++++++ > drivers/phy/qualcomm/phy-qcom-qmp.h | 12 +++ > 2 files changed, 122 insertions(+) Hello Kishon, Are there other changes you'd like me to make? Regards.