On Thu 11 Apr 13:51 PDT 2019, Jeffrey Hugo wrote: > diff --git a/arch/arm64/boot/dts/qcom/msm8998-clam.dtsi b/arch/arm64/boot/dts/qcom/msm8998-clam.dtsi [..] > +&tlmm { > + gpio-reserved-ranges = <0 4>, <81 4>; Did you double check that you actually need these? (Iirc boot testing is enough) > + > + touchpad: touchpad { > + config { > + pins = "gpio123"; > + bias-pull-up; /* pull up */ > + }; > + }; > +}; [..] > diff --git a/arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dts b/arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dts [..] > +/ { > + model = "Lenovo Miix 630"; > + compatible = "qcom,msm8998-clam"; compatible = "lenovo,miix-630", "qcom,msm8998"; > + > + /* bootloader doesn't understand DT, so no qcom,board-id */ You can omit this comment, as I don't think people will miss these non-standard properties. Regards, Bjorn