On 27/03/2019 13:38, Sibi Sankar wrote: > Add the shared cx/mx and sensor sub-system's cx and mx > power-domains found on MSM8998. > > Signed-off-by: Sibi Sankar <sibis@xxxxxxxxxxxxxx> > --- > drivers/soc/qcom/rpmpd.c | 36 ++++++++++++++++++++++++++++++++++++ > 1 file changed, 36 insertions(+) > > diff --git a/drivers/soc/qcom/rpmpd.c b/drivers/soc/qcom/rpmpd.c > index 238a9e02e890..706a3f63038e 100644 > --- a/drivers/soc/qcom/rpmpd.c > +++ b/drivers/soc/qcom/rpmpd.c > @@ -19,9 +19,12 @@ > /* Resource types */ > #define RPMPD_SMPA 0x61706d73 /* smpa */ > #define RPMPD_LDOA 0x616f646c /* ldoa */ > +#define RPMPD_RWCX 0x78637772 /* rwcx */ > #define RPMPD_RWMX 0x786d7772 /* rwmx */ > #define RPMPD_RWLC 0x636c7772 /* rwlc */ > #define RPMPD_RWLM 0x6d6c7772 /* rwlm */ > +#define RPMPD_RWSC 0x63737772 /* rwsc */ > +#define RPMPD_RWSM 0x6d737772 /* rwsm */ I do not see any value in the comments. Maybe remove them? I will take a closer look at patches 7-9 on Monday. Regards.