On 4/4/19 07:55, Mark Brown wrote: > On Thu, Apr 04, 2019 at 07:09:22AM +0200, Niklas Cassel wrote: >> From: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@xxxxxxxxxx> >> >> Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@xxxxxxxxxx> >> --- >> drivers/regulator/qcom_spmi-regulator.c | 7 +++++++ >> 1 file changed, 7 insertions(+) > > This doesn't build: > > CC drivers/regulator/qcom_spmi-regulator.o > drivers/regulator/qcom_spmi-regulator.c: In function ‘qcom_spmi_regulator_probe’: > drivers/regulator/qcom_spmi-regulator.c:1837:29: error: ‘SPMI_REGULATOR_LOGICAL_TYPE_HFS430’ undeclared (first use in this function); did you mean ‘SPMI_REGULATOR_LOGICAL_TYPE_FTSMPS’? > if (vreg->logical_type == SPMI_REGULATOR_LOGICAL_TYPE_HFS430) { > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > SPMI_REGULATOR_LOGICAL_TYPE_FTSMPS > drivers/regulator/qcom_spmi-regulator.c:1837:29: note: each undeclared identifier is reported only once for each function it appears in > yeah, the SPMI regulator changes are still pending