Hi, On 22/03/19 9:42 PM, Marc Gonzalez wrote: > Copy init sequence from downstream: > https://source.codeaurora.org/quic/la/kernel/msm-4.4/tree/arch/arm/boot/dts/qcom/msm8998-v2.dtsi?h=LE.UM.1.3.r3.25#n372 Can't we instead have reference to HW manual or datasheet? > > Signed-off-by: Marc Gonzalez <marc.w.gonzalez@xxxxxxx> > --- > .../devicetree/bindings/phy/qcom-qmp-phy.txt | 5 + > drivers/phy/qualcomm/phy-qcom-qmp.c | 110 ++++++++++++++++++ > drivers/phy/qualcomm/phy-qcom-qmp.h | 12 ++ > 3 files changed, 127 insertions(+) > > diff --git a/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt b/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt > index 5d181fc3cc18..6000ae34b12b 100644 > --- a/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt > +++ b/Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt > @@ -11,6 +11,7 @@ Required properties: > "qcom,msm8996-qmp-usb3-phy" for 14nm USB3 phy on msm8996, > "qcom,msm8998-qmp-usb3-phy" for USB3 QMP V3 phy on msm8998, > "qcom,msm8998-qmp-ufs-phy" for UFS QMP phy on msm8998, > + "qcom,msm8998-qmp-pcie-phy" for PCIe QMP phy on msm8998, > "qcom,sdm845-qmp-usb3-phy" for USB3 QMP V3 phy on sdm845, > "qcom,sdm845-qmp-usb3-uni-phy" for USB3 QMP V3 UNI phy on sdm845, > "qcom,sdm845-qmp-ufs-phy" for UFS QMP phy on sdm845. > @@ -48,6 +49,8 @@ Required properties: > "aux", "cfg_ahb", "ref". > For "qcom,msm8998-qmp-ufs-phy" must contain: > "ref", "ref_aux". > + For "qcom,msm8998-qmp-pcie-phy" must contain: > + "aux", "cfg_ahb", "ref". > For "qcom,sdm845-qmp-usb3-phy" must contain: > "aux", "cfg_ahb", "ref", "com_aux". > For "qcom,sdm845-qmp-usb3-uni-phy" must contain: > @@ -70,6 +73,8 @@ Required properties: > For "qcom,msm8998-qmp-usb3-phy" must contain > "phy", "common". > For "qcom,msm8998-qmp-ufs-phy": no resets are listed. > + For "qcom,msm8998-qmp-pcie-phy" must contain: > + "phy", "common", "cfg". > For "qcom,sdm845-qmp-usb3-phy" must contain: > "phy", "common". > For "qcom,sdm845-qmp-usb3-uni-phy" must contain: Please send the dt binding in a separate patch. Thanks Kishon
