On Fri, Mar 15, 2019 at 12:41 AM Enrico Weigelt, metux IT consult <info@xxxxxxxxx> wrote: > > Instead of fetching out data from a struct resource for passing > it to devm_ioremap(), directly use devm_ioremap_resource() I don't see any advantage of this change. See also below. > --- a/drivers/tty/serial/8250/8250_dw.c > +++ b/drivers/tty/serial/8250/8250_dw.c > @@ -526,7 +526,7 @@ static int dw8250_probe(struct platform_device *pdev) > p->set_ldisc = dw8250_set_ldisc; > p->set_termios = dw8250_set_termios; > > - p->membase = devm_ioremap(dev, regs->start, resource_size(regs)); > + p->membase = devm_ioremap_resource(dev, regs); > if (!p->membase) And how did you test this? devm_ioremap_resource() returns error pointer in case of error. > return -ENOMEM; -- With Best Regards, Andy Shevchenko
