On Thu, Feb 21, 2019 at 10:42:01AM +0100, Marc Gonzalez wrote: > On 19/02/2019 17:39, Mark Brown wrote: > > On Tue, Feb 19, 2019 at 05:02:46PM +0100, Marc Gonzalez wrote: > > No, it's perfectly normal for machine constraints to stop drivers from > > doing things so we shouldn't warn on this - it would get incredibly > > noisy if we started printing every time constraints didn't let us do > > something at info level. Debug level might be viable, or definitely > > vdbg or trace points. > Several functions return an error (and log a KERN_ERR message) if their > corresponding flag is not set: > > regulator_check_voltage() REGULATOR_CHANGE_VOLTAGE That's a bug due to an incomplete implementation, what it's supposed to be doing there is checking if the voltage request is satisfied by the current voltage and returning an error only if the requested voltage is out of range. > regulator_check_current_limit() REGULATOR_CHANGE_CURRENT This one is less clear than anything else - we might want to error out here if the device is somehow relying on being able to lower the current limit for safety. We'd need an audit of users. > regulator_mode_constrain() REGULATOR_CHANGE_MODE This one is also a bug, modes barely mean anything anyway.
Attachment:
signature.asc
Description: PGP signature
