On Tue, Feb 12, 2019 at 03:35:40PM -0700, Jordan Crouse wrote: <snip> > > > struct llcc_slice_desc *desc; > > > u32 sz, count; > > > > > > + if (IS_ERR(drv_data)) > > > > IS_ERR_OR_NULL would catch the null from above. Are you using the EPROBE_DEFER > > to probe defer somewhere else? > > Yeah, the intent was to automatically return -EPROBE_DEFER until the sub-system > came along and initialized it so that the leaf driver could tell the difference > between an non existent LLCC and just one that hasn't been set up yet. Its a > bit contrived. I'm okay with leaving it as NULL and then letting the leaf driver > decide if it wants to try again later. OK, if you don't mind I can just change it to the above without you sending in a new patch. Andy
